Minor refactor of better for desugar #23448
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
force-pushed
the
refactor/desugar-for
branch
from
f2a2d13 to
4460166
Compare
|
In this case, I think the guard conditions are objectively hard to read. (As I learned when I had to read them.) The guard condition says The existing guard might be more conservative when the new feature is experimental (and the rest of the condition is never evaluated), but presumably the feature is actually exercised now. I think the readability argument carries more weight, but if you don't see the value, then feel free to ignore the PR. |
|
I wished to say, if you feel that the potential benefit is outweighed by the work to review the change, please ignore the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move the complex guards into the body of the case and use an
ifconditional to handleis better forsor legacy.The list of enumerators is split into a prefix of aliases and suffix of remaining. The guards made this obscure. (Probably the prefix of aliases is not long, so taking the
spanis cheap enough.)Make the duplicated code in the last case a more exact copy. (But don't bother to DRY it out.)